Support NetBox v3 #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillaume001
force-pushed
the
conf-netbox3
branch
from
c18f951 to
5b3a9c6
Compare
adoom42
reviewed
Dec 8, 2021
| python36, | ||
| python36-devel, | ||
| python39, | ||
| python39-devel, |
There was a problem hiding this comment.
Most distros don't have packages named python39 or python39-devel, at least not available in their main repos. The only match I could find is in CentOS 8 AppStream. It would be best if these could be overridden. For example, in CentOS 7, the SCL package is named rh-python38-python.
Author
There was a problem hiding this comment.
This module supports CentOS and RedHat 8 only... So I bump this version to match with NetBox v3 requirements (with main repositories of these distros). If you want to make this module compatible with CentOS 7, indeed you must have as a prerequisite the SCL repository and specify the version 3.8. I don't think so this feature should be in this PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.