Skip to content

Fix for Android mobile browsers: soft keyboards do not send key events except for ENTER so we just take the last line from textarea without the prompt prefix + fix for iOS mobile browsers: soft keyboard did not show on some iOS versions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for Android mobile browsers: soft keyboards do not send key events except for ENTER so we just take the last line from textarea without the prompt prefix + fix for iOS mobile browsers: soft keyboard did not show on some iOS versions #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46563d4
Fix for mobile browsers: soft keyboards do not send key events except…
markostamcar May 13, 2020
5a83864
iOS Safari keyboard fix
markostamcar May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/terminal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const createElement = root => {
el.value = '';

root.appendChild(el);
document.body.ontouchend = function() { el.focus(); };

return el;
};
Expand Down Expand Up @@ -128,7 +129,7 @@ const executor = commands => (cmd, ...args) => cb => {
};

// Handle keyboard events
const keyboard = (parse) => {
const keyboard = ($element, prompt, parse) => {
let input = [];
const keys = {8: 'backspace', 13: 'enter'};
const ignoreKey = code => code >= 33 && code <= 40;
Expand All @@ -138,7 +139,7 @@ const keyboard = (parse) => {
keypress: (ev) => {
if (key(ev) === 'enter') {
const str = input.join('').trim();
parse(str);
parse(str || $element.value.split(/\n/)[$element.value.split(/\n/).length - 1].replace(prompt(), ''));
input = [];
} else if (key(ev) !== 'backspace') {
input.push(String.fromCharCode(ev.which || ev.keyCode));
Expand Down Expand Up @@ -190,7 +191,7 @@ export const terminal = (opts) => {
const render = renderer(tickrate, onrender);
const parse = parser(onparsed);
const focus = () => setTimeout(() => $element.focus(), 1);
const kbd = keyboard(parse);
const kbd = keyboard($element, prompt, parse);
const clear = () => ($element.value = '');
const input = ev => busy
? ev.preventDefault()
Expand Down