Skip to content

iio: adc: adrv9002: fix frequency hopping table configuration #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

iio: adc: adrv9002: fix frequency hopping table configuration #2967

wants to merge 1 commit into from

Conversation

nunojsa
Copy link
Collaborator

@nunojsa nunojsa commented Oct 2, 2025 •
edited
Loading

PR Description

Fix multiple issues in the frequency hopping bin table write function:

  • Correct typo "bellow" to "below" in comment
  • Fix off-by-one error in entry bounds check (should be >= not >)
  • Use correct rx20_if variable for rx2OffsetFrequencyHz instead of rx10_if
  • Use correct rx2_gain variable for rx2GainIndex instead of rx1_gain

These fixes ensure proper configuration of RX2 channel parameters and prevent potential buffer overflow when the entry index equals max_sz.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@nunojsa
iio: adc: adrv9002: fix frequency hopping table configuration
a72838d 
Fix multiple issues in the frequency hopping bin table write function:
- Correct typo "bellow" to "below" in comment
- Fix off-by-one error in entry bounds check (should be >= not >)
- Use correct rx20_if variable for rx2OffsetFrequencyHz instead of rx10_if
- Use correct rx2_gain variable for rx2GainIndex instead of rx1_gain

These fixes ensure proper configuration of RX2 channel parameters and
prevent potential buffer overflow when the entry index equals max_sz.

Signed-off-by: Nuno Sá <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nunojsa