SHARK-172 - Make ppd2 unit test pass #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for ReduceSinkOperator during merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Operator.initEvaluators() execution, the number of evaluators that get initialised for ReduceSinkOperators relates directly to the numDistributionKeys field. Prior to this change, the number of elements in the keyCols array and the value of numDistributionKeys were potentially out of sync which would cause one of the ExprNodeColumnEvaluator's to have null fields and therefore throw a NPE during the ppd2 test run.
I've piggy backed this on the decision to copy across ExprNodeDesc's due to the direct link between that array and numDistributionKeys during Operator.initEvaluators() execution.