Sourcery Starbot ⭐ refactored amitkot/obsidian-html #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

SourceryAI wants to merge 1 commit into amitkot:master from SourceryAI:master

SourceryAI commented Apr 26, 2022

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/obsidian-html master
git merge --ff-only FETCH_HEAD
git reset HEAD^


          'Refactored by Sourcery'

366323e

SourceryAI commented

View reviewed changes

ci/tests/basic_regression_test.py

Comment on lines -24 to +25

    
                  paths = {}

                  this_file_path              = os.path.realpath(__file__)                                        # (..)/obsidian-html/ci/tests/__filename__

                  paths['ci_tests']           = Path(this_file_path).parent                                       # (..)/obsidian-html/ci/tests/

                  paths = {'ci_tests': Path(this_file_path).parent}

Author

SourceryAI Apr 26, 2022

Function get_paths refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)
Merge dictionary assignment with declaration (merge-dict-assign)

This removes the following comments ( why? ):

# (..)/obsidian-html/ci/tests/

ci/tests/basic_regression_test.py

Comment on lines -73 to +72

    
                  if output_dict:

                      return {'soup': soup, 'url': url}

                  else:

                      return soup

                  return {'soup': soup, 'url': url} if output_dict else soup

Author

SourceryAI Apr 26, 2022

Function html_get refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

ci/tests/basic_regression_test.py

Comment on lines -93 to +89

    
                  # Merge the two

                  config = MergeDictRecurse(sys_config, default_config)

                  return config

                  return MergeDictRecurse(sys_config, default_config)

Author

SourceryAI Apr 26, 2022

Function get_default_config refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

This removes the following comments ( why? ):

# Merge the two

ci/tests/basic_regression_test.py

Comment on lines -277 to +270

Author

SourceryAI Apr 26, 2022

Function TestDefaultMode.test_C_rss refactored with the following changes:

Simplify sequence length comparison (simplify-len-comparison)

ci/tests/basic_regression_test.py

Comment on lines -456 to +465

    
                  for i, v in enumerate(sys.argv):

                      if v == '-r':

                          run_setup = True

                  for v in sys.argv:

                      if v == '-c':

                          run_cleanup = True

                      if v == 'v':

                      elif v == '-r':

                          run_setup = True

                      elif v == 'v':

                          verbose = True

                  # get paths

                  paths = get_paths()

Author

SourceryAI Apr 26, 2022

Lines 456-466 refactored with the following changes:

Remove unnecessary calls to enumerate when the index is not used (remove-unused-enumerate)
Simplify conditional into switch-like form (switch)

obsidianhtml/RssFeed.py

Comment on lines -353 to +338

    
                  header = soup.body.find('h'+str(header_level))

                  header = soup.body.find(f'h{str(header_level)}')

Author

SourceryAI Apr 26, 2022

Function selector_first_header refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

obsidianhtml/RssFeed.py

Comment on lines -367 to +355

    
                              for i in range(arg[1]):

                              for _ in range(arg[1]):

                                  el = el.parent

                              value += el.name

                          # Get filename minus suffix

Author

SourceryAI Apr 26, 2022

Function selector_path refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

This removes the following comments ( why? ):

# Get filename minus suffix

obsidianhtml/__init__.py

    
                      md.dst_path = md.dst_path.parent.joinpath('index__2.md')

                      md.rel_dst_path = md.dst_path.relative_to(md.dst_folder_path)

Author

SourceryAI Apr 26, 2022

Function ConvertMarkdownPageToHtmlPage refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

obsidianhtml/lib.py

Comment on lines -38 to +41

    
                  header = ''

                  if len(parts) > 1:

                      header = parts[1]

                  header = parts[1] if len(parts) > 1 else ''

                  if filename[-3:] != '.md':

                      filename += '.md'

Author

SourceryAI Apr 26, 2022

Function GetObsidianFilePath refactored with the following changes:

Replace if statement with if expression (assign-if-exp)
Move setting of default value for variable into else branch (introduce-default-else)

obsidianhtml/lib.py

Comment on lines -218 to +217

    
                      # other cases -> copy over

                      if isinstance(update_dict[k], list):

                          base_dict[k] = v.copy()

                      else:

                          base_dict[k] = v

                      # other cases -> copy over

                      base_dict[k] = v.copy() if isinstance(update_dict[k], list) else v

Author

SourceryAI Apr 26, 2022

Function MergeDictRecurse refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet