Skip to content

Dmesg log collection #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 28, 2025
Merged

Dmesg log collection #35

merged 12 commits into from
Aug 28, 2025

Conversation

alexandraBara
Copy link
Collaborator

@alexandraBara alexandraBara commented Aug 14, 2025 •
edited
Loading

Notice log dmesg collection does not run by default. Extra collection args needs to be specified: --collect-rotated-logs=True
Sample run:

 node-scraper  run-plugins DmesgPlugin --collect-logs=True
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Log path: ./scraper_logs_pp_128_a5_1_2025_08_14-01_03_48_PM
  2025-08-14 13:03:48 CDT       INFO               nodescraper | System Name: <>
  2025-08-14 13:03:48 CDT       INFO               nodescraper | System SKU: None
  2025-08-14 13:03:48 CDT       INFO               nodescraper | System Platform: None
  2025-08-14 13:03:48 CDT       INFO               nodescraper | System location: SystemLocation.LOCAL
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args
  2025-08-14 13:03:48 CDT       INFO               nodescraper | --------------------------------------------------
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Running plugin DmesgPlugin
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Initializing connection: InBandConnectionManager
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Using local shell
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Checking OS family
  2025-08-14 13:03:48 CDT       INFO               nodescraper | OS Family: LINUX
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Running data collector: DmesgCollector
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Running dmesg command on system
  2025-08-14 13:03:48 CDT       INFO               nodescraper | Collected dmesg log: dmesg_log.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Collected dmesg log: dmesg.0.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Collected dmesg log: dmesg.1.gz.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Collected dmesg log: dmesg.2.gz.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Collected dmesg log: dmesg.3.gz.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Collected dmesg log: dmesg.4.gz.log
  2025-08-14 13:03:49 CDT       INFO               nodescraper | (DmesgPlugin) Dmesg data collected
  2025-08-14 13:03:49 CDT       INFO               nodescraper | Running data analyzer: DmesgAnalyzer
  2025-08-14 13:03:50 CDT      ERROR               nodescraper | (DmesgPlugin) task detected errors (2 warnings|10 errors)
  2025-08-14 13:03:50 CDT       INFO               nodescraper | Closing connections
  2025-08-14 13:03:50 CDT       INFO               nodescraper | Running result collators
  2025-08-14 13:03:50 CDT       INFO               nodescraper | Running TableSummary result collator
  2025-08-14 13:03:50 CDT       INFO               nodescraper |

+-------------------------+--------+-----------------------------+
|  Connection              | Status | Message                     |
+-------------------------+--------+-----------------------------+
|  InBandConnectionManager | UNSET  | task completed successfully |
+-------------------------+--------+-----------------------------+

+-------------+--------+-------------------------------------------------------------+
|  Plugin      | Status | Message                                                     |
+-------------+--------+-------------------------------------------------------------+
|  DmesgPlugin | ERROR  | Analysis error: task detected errors (2 warnings|10 errors) |
+-------------+--------+-------------------------------------------------------------+

  2025-08-14 13:03:50 CDT       INFO               nodescraper | Data written to csv file: ./scraper_logs_pp_128_a5_1_2025_08_14-01_03_48_PM/nodescraper.csv

Dmesg logs collected are written to the log folder:

ls ./scraper_logs_pp_128_a5_1_2025_08_14-01_03_48_PM/dmesg_plugin/dmesg_collector/
command_artifacts.json  dmesg.0.log  dmesg.1.gz.log  dmesg.2.gz.log  dmesg.3.gz.log  dmesg.4.gz.log  dmesg.log  dmesg_log.log  events.json  result.json

@alexandraBara alexandraBara requested a review from sternma August 14, 2025 18:06
landrews-amd
landrews-amd requested changes Aug 15, 2025
View reviewed changes
Base automatically changed from alex_dmesg to development August 18, 2025 14:09
landrews-amd
landrews-amd approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@landrews-amd landrews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small changed needed, otherwise lgtm

nodescraper/plugins/inband/dmesg/dmesgdata.py Outdated
@@ -34,6 +34,7 @@ class DmesgData(DataModel):
"""Data model for in band dmesg log"""

dmesg_content: str
dmesg_logs: list[dict] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data model attribute is unused and can be removed.

@alexandraBara alexandraBara merged commit 3a0b75c into development Aug 28, 2025
5 checks passed
@alexandraBara alexandraBara deleted the alex_dmesg_logs branch August 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landrews-amd landrews-amd landrews-amd approved these changes

@sternma sternma Awaiting requested review from sternma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandraBara @landrews-amd