Skip to content

Conversation

@ianlcsd
Copy link

@ianlcsd ianlcsd commented Oct 25, 2017

  1. not caching LogicalRelation
  2. adding identifier to LogicalRelation.simpleString

Copy link
Author

@ianlcsd ianlcsd Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we keep the $relation?
the old string does not have table identifier.

Relation[c_date#1,c_count#2,c_type#3,c_number#4,c_domain#5] parquet

the new throws away the information of relation type

Relation[c_date#1,c_count#2,c_type#3,c_number#4,c_domain#5] test__v0_0

Copy link
Author

@ianlcsd ianlcsd Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe to keep both?

Relation[c_date#1,c_count#2,c_type#3,c_number#4,c_domain#5] parquet test__v0_0

1. not caching LogicalRelation
2. adding identifier to LogicalRelation.toString ()
@ianlcsd ianlcsd changed the title SPY-1453 SPY-1453: disable LogicalRelation for CSD and include identifier in simple String Oct 26, 2017
@ianlcsd ianlcsd merged commit 8eac3a7 into alteryx:csd-2.2 Oct 26, 2017
@ianlcsd
Copy link
Author

ianlcsd commented Oct 26, 2017

merged it per talk with @markhamstra

@ianlcsd ianlcsd changed the title SPY-1453: disable LogicalRelation for CSD and include identifier in simple String SPY-1453: disable LogicalRelation caching for CSD and include identifier in simple String Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant