SKIPME: Hackathon List jobs by JobGroup #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for whatever reason, the original extras pom version bump was from -1- to -6-, so do we want to go back to -1-, or use -5-? |
davidnavas
reviewed
Mar 24, 2017
| } | ||
|
|
||
| private def makeTimeline( | ||
| protected def makeTimeline( |
davidnavas
reviewed
Mar 24, 2017
| } else { | ||
| "" | ||
| } | ||
| }"' + |
davidnavas
reviewed
Mar 24, 2017
| } | ||
|
|
||
| val helpText = | ||
| """A job is triggered by an action, like count() or saveAsTextFile().""" + |
There was a problem hiding this comment.
seems like this can be one """ """.strip....
davidnavas
reviewed
Mar 24, 2017
| } else { | ||
| "" | ||
| } | ||
| }">' + |
There was a problem hiding this comment.
yep, confused by this double-quote as well. Presumably the end-brace matches the brace on line 162, and the end angle bracket matches the open-angle for the div tag on line 157. Unclear what the double-quote in between is for, though?
Author
|
jttp |
1 similar comment
Author
|
jttp |
|
Seems fine to me, not sure why the checks are all failing though :( |
|
LGTM |
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Nov 7, 2017
(cherry picked from commit be109ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will do more clean up once I am done with the production query performance debugging. I plan to add more stats like 'First job submitted at:' and etc. to help the debugging.