SKIPME: Clear just the bits that are necessary #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
How should I run tests/release? |
|
I'll take a look at the tests -- essentially you want to run them locally and ignore a couple of known, benign test failures. |
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Nov 7, 2017
…yx#173) * Support configuring SSL using PEM files. * Address some missed comments * Fix import ordering * Slight rewording of comments * Fix scalastyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As measured locally (amazon's VM performance may vary), allocating a 12 million entry BitSet and then clearing a million times takes one minute. When you have a skewed query that has one entry that matches very well (say, 12 million entries against customer 0) and then another 6 million with one entry each, the outer join code can wind up taking several minutes clearing bits that aren't strictly required.
This doesn't seem like it's the entire cause of slowness for @yeweizhang 's query (6 minutes isn't the whole measured slowness, and I don't think cpu cache pollution will make up the balance), but it seems worth fixing.