Skip to content

Implement the fmod function #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2015
Merged

Implement the fmod function #129

merged 2 commits into from
Dec 15, 2015

Conversation

@mbautin
Copy link

@mbautin mbautin commented Dec 14, 2015

@markhamstra
Copy link

markhamstra commented Dec 14, 2015

Should probably also add to sql/core/src/main/scala/org/apache/spark/sql/functions.scala for DF DSL.

@markhamstra
Copy link

markhamstra commented Dec 15, 2015

Is there a reason not to handle all the parameter types that pmod does? Wouldn't doing so be little more than copying case class Pmod and removing the variations on if (r < 0) to use just the else branches?

mbautin added a commit that referenced this pull request Dec 15, 2015
@mbautin
Merge pull request #129 from mbautin/csd-1.5_fmod
18a4254 
Implement the fmod function
@mbautin mbautin merged commit 18a4254 into alteryx:csd-1.5 Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbautin @markhamstra