dev: Defer free of skbs in flush_backlog

Subash Abhinov Kasiviswanathan · gregkh · commit d109acd58052 · 2020-07-31T18:39:30.000+02:00
[ Upstream commit 7df5cb7 ] IRQs are disabled when freeing skbs in input queue. Use the IRQ safe variant to free skbs here. Fixes: 145dd5f ("net: flush the softnet backlog in process context") Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/net/core/dev.c b/net/core/dev.c
@@ -5229,7 +5229,7 @@ static void flush_backlog(struct work_struct *work)
 	skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {
 		if (skb->dev->reg_state == NETREG_UNREGISTERING) {
 			__skb_unlink(skb, &sd->input_pkt_queue);
-			kfree_skb(skb);
+			dev_kfree_skb_irq(skb);
 			input_queue_head_incr(sd);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -5229,7 +5229,7 @@ static void flush_backlog(struct work_struct *work)`
`5229`	`5229`	`skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {`
`5230`	`5230`	`if (skb->dev->reg_state == NETREG_UNREGISTERING) {`
`5231`	`5231`	`__skb_unlink(skb, &sd->input_pkt_queue);`
`5232`		`- kfree_skb(skb);`
	`5232`	`+ dev_kfree_skb_irq(skb);`
`5233`	`5233`	`input_queue_head_incr(sd);`
`5234`	`5234`	`}`
`5235`	`5235`	`}`