dev: Defer free of skbs in flush_backlog

Subash Abhinov Kasiviswanathan · davem330 · commit 7df5cb75cfb8 · 2020-07-24T19:59:22.000-07:00
IRQs are disabled when freeing skbs in input queue. Use the IRQ safe variant to free skbs here. Fixes: 145dd5f ("net: flush the softnet backlog in process context") Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/core/dev.c b/net/core/dev.c
@@ -5601,7 +5601,7 @@ static void flush_backlog(struct work_struct *work)
 	skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {
 		if (skb->dev->reg_state == NETREG_UNREGISTERING) {
 			__skb_unlink(skb, &sd->input_pkt_queue);
-			kfree_skb(skb);
+			dev_kfree_skb_irq(skb);
 			input_queue_head_incr(sd);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -5601,7 +5601,7 @@ static void flush_backlog(struct work_struct *work)`
`5601`	`5601`	`skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {`
`5602`	`5602`	`if (skb->dev->reg_state == NETREG_UNREGISTERING) {`
`5603`	`5603`	`__skb_unlink(skb, &sd->input_pkt_queue);`
`5604`		`- kfree_skb(skb);`
	`5604`	`+ dev_kfree_skb_irq(skb);`
`5605`	`5605`	`input_queue_head_incr(sd);`
`5606`	`5606`	`}`
`5607`	`5607`	`}`