Force SCons to use GCC when building .c files #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm it runs as previously on my Ubuntu Linux machine. I will review the changes more fully later |
|
Alright, so the changes are quite simple, but I feel they are a bit too hard coded, especially when we're gonna add many more languages. |
|
The most recent changes don't work, SCons has the same behaviour as before my commit. |
…ted SCons's behaviour to using MSVC This reverts commit 688b93a.
Amaras
approved these changes
Nov 11, 2021
Co-authored-by: Sammy Plat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SCons on Windows when MSVC is installed. Previously it would attempt to use MSVC, but fail due to trying to pass it gcc libraries to link.
This needs testing on Linux before it is merged.
It may be better to have the sconstruct file detect which compiler is being used and adjust the calling based on that, so users with only MSVC or with clang can also build. Fixing it for now would still seem prudent, and we can change the behaviour later if wanted.