fix: fix undefined behavior with mutable references

examples/reti/artifacts/ValidatorRegistry.approval.teal

@@ -530,7 +530,7 @@ getPools:
 
 *if0_end:
 	// examples/reti/validatorRegistry.algo.ts:325
-	// retData.push(poolSet[i])
+	// retData.push(clone(poolSet[i]))
 	frame_dig 0 // retData: PoolInfo[]
 	frame_dig 1 // poolSet: (uint64,uint16,uint64)[24]
 	frame_dig 2 // i: uint64
@@ -933,7 +933,7 @@ getStakedPoolsForAccount:
 
 	// *if4_consequent
 	// examples/reti/validatorRegistry.algo.ts:390
-	// retData.push(poolSet[i])
+	// retData.push(clone(poolSet[i]))
 	frame_dig 0 // retData: ValidatorPoolKey[]
 	frame_dig 1 // poolSet: (uint64,uint64,uint64)[6]
 	frame_dig 2 // i: uint64
@@ -2376,7 +2376,7 @@ addStake:
 
 *if10_end:
 	// examples/reti/validatorRegistry.algo.ts:696
-	// this.updateStakerPoolSet(staker, poolKey)
+	// this.updateStakerPoolSet(staker, clone(poolKey))
 	frame_dig 3 // findRet: ((uint64,uint64,uint64),bool,bool)
 	store 255 // full array
 	load 255 // full array
@@ -2387,7 +2387,7 @@ addStake:
 	// examples/reti/validatorRegistry.algo.ts:699
 	// this.callPoolAddStake(
 	//       stakedAmountPayment,
-	//       poolKey,
+	//       clone(poolKey),
 	//       mbrAmtLeftBehind,
 	//       isNewStakerToValidator,
 	//       isNewStakerToProtocol

examples/reti/validatorRegistry.algo.ts

@@ -322,7 +322,7 @@ export class ValidatorRegistry extends Contract {
         // reached end of list...  we don't replace values here because pools can't be removed
         break;
       }
-      retData.push(poolSet[i]);
+      retData.push(clone(poolSet[i]));
     }
     return retData;
   }
@@ -387,7 +387,7 @@ export class ValidatorRegistry extends Contract {
     const poolSet = clone(this.stakerPoolSet(staker).value);
     for (let i = 0; i < poolSet.length; i += 1) {
       if (poolSet[i].id !== 0) {
-        retData.push(poolSet[i]);
+        retData.push(clone(poolSet[i]));
       }
     }
     return retData;
@@ -693,12 +693,12 @@ export class ValidatorRegistry extends Contract {
     }
 
     // Update StakerPoolList for this found pool (new or existing)
-    this.updateStakerPoolSet(staker, poolKey);
+    this.updateStakerPoolSet(staker, clone(poolKey));
     // Send the callers algo amount (- mbrAmtLeftBehind) to the specified staking pool, and it then updates
     // the staker data.
     this.callPoolAddStake(
       stakedAmountPayment,
-      poolKey,
+      clone(poolKey),
       mbrAmtLeftBehind,
       isNewStakerToValidator,
       isNewStakerToProtocol

package.json

@@ -62,6 +62,7 @@
     "@microsoft/tsdoc": "^0.14.2",
     "@playwright/test": "^1.40.1",
     "argparse": "^2.0.1",
+    "chalk": "^5.4.1",
     "dotenv": "^16.3.1",
     "glob": "^10.3.10",
     "hi-base32": "^0.5.1",

scripts/compile_all.ts

@@ -22,6 +22,7 @@ const examplesArtifacts = {
 async function main() {
   const files = globSync(path.join(__dirname, '../**/*.algo.ts'));
   files.forEach((file) => {
+    if (file.includes('reference_errors')) return;
     if (file.includes('compile_errors')) return;
     const isExample = file.includes('examples/');
     const project = isExample ? EXAMPLES_PROJECT : TESTS_PROJECT;

src/lib/compiler.ts

@@ -14,11 +14,11 @@ import langspec from '../static/langspec.json';
 import { VERSION } from '../version';
 import { optimizeTeal } from './optimize';
 import { type ARC56Contract, type StructField } from '../types/arc56.d';
+import { checkRefs } from './ref_checker2';
+import { getExpressionChain, ExpressionChainNode } from './utils';
 
 const MULTI_OUTPUT_TYPES = ['split uint128', 'divmodw output', 'vrf return values', 'ecdsa pubkey'];
 
-type ExpressionChainNode = ts.ElementAccessExpression | ts.PropertyAccessExpression | ts.CallExpression;
-
 type OnComplete = 'NoOp' | 'OptIn' | 'CloseOut' | 'ClearState' | 'UpdateApplication' | 'DeleteApplication';
 const ON_COMPLETES: ['NoOp', 'OptIn', 'CloseOut', 'ClearState', 'UpdateApplication', 'DeleteApplication'] = [
   'NoOp',
@@ -2038,6 +2038,7 @@ export default class Compiler {
         if (this.lastType.kind !== 'dynamicArray') throw new Error('Can only push to dynamic array');
         if (!this.isDynamicArrayOfStaticType(this.lastType))
           throw new Error('Cannot push to dynamic array of dynamic types');
+
         this.processNode(node.getArguments()[0]);
         this.checkEncoding(node.getArguments()[0], this.lastType);
         this.pushVoid(node, 'concat');
@@ -2837,6 +2838,10 @@ export default class Compiler {
 
     // Go over all the files we are importing and check for number keywords
     [sourceFile, ...importedFiles].forEach((f) => {
+      if (f === undefined) return;
+
+      checkRefs(f, path.relative(this.cwd, f.getFilePath()));
+
       f?.getStatements().forEach((s) => {
         const numberKeywords = s.getDescendantsOfKind(ts.SyntaxKind.NumberKeyword);
 
@@ -3696,42 +3701,6 @@ export default class Compiler {
     this.processArrayElements(node.getElements(), node);
   }
 
-  /**
-   *
-   * @param node The top level node to process
-   * @param chain The existing expression chain to add to
-   * @returns The base expression and reversed expression chain `this.txn.sender` ->
-   * `{ chain: [this.txn, this.txn.sender], base: [this] }`
-   */
-  private getExpressionChain(
-    node: ExpressionChainNode,
-    chain: ExpressionChainNode[] = []
-  ): { chain: ExpressionChainNode[]; base: ts.Node } {
-    chain.push(node);
-
-    /**
-     * The expression on the given node
-     * `this.txn.sender` -> `this.txn`
-     */
-    let expr: ts.Expression = node.getExpression();
-
-    /* this.txn.applicationArgs! -> this.txn.applicationArgs */
-    if (expr.isKind(ts.SyntaxKind.NonNullExpression)) {
-      expr = expr.getExpression();
-    }
-
-    if (
-      expr.isKind(ts.SyntaxKind.ElementAccessExpression) ||
-      expr.isKind(ts.SyntaxKind.PropertyAccessExpression) ||
-      expr.isKind(ts.SyntaxKind.CallExpression)
-    ) {
-      return this.getExpressionChain(expr, chain);
-    }
-
-    chain.reverse();
-    return { base: expr, chain };
-  }
-
   private getAccessChain(node: ts.ElementAccessExpression, chain: ts.ElementAccessExpression[] = []) {
     chain.push(node);
 
@@ -6316,7 +6285,7 @@ export default class Compiler {
       }
     }
 
-    const { base, chain } = this.getExpressionChain(node);
+    const { base, chain } = getExpressionChain(node);
 
     if (base.isKind(ts.SyntaxKind.ParenthesizedExpression)) {
       if (!base.getExpression().isKind(ts.SyntaxKind.BinaryExpression))