This repository was archived by the owner on Dec 16, 2022. It is now read-only.
fix(Angular IS): enable esModuleInterop #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a problem you can encounter on codeandbox ``` lite_1.default is not a function ```
francoischalifour
approved these changes
Sep 21, 2021
Contributor
francoischalifour
left a comment
francoischalifour
left a comment
There was a problem hiding this comment.
I think that's a better solution than relying on @algolia/client-search, where we'd likely loose SSR compatibility. The lite client is made for the web and has other optimizations.
sarahdayan
approved these changes
Sep 21, 2021
Member
sarahdayan
left a comment
sarahdayan
left a comment
There was a problem hiding this comment.
I agree with @francoischalifour, we want to keep the lite client. This is a build problem, so it's best solved at build level.
Contributor
Author
|
Thank you both! |
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…-app#527) * fix(Angular IS): enable esModuleInterop This works around a problem you can encounter on codeandbox ``` lite_1.default is not a function ``` * updated snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a problem you can encounter on codeandbox.
Could using client-search instead of algoliasearch/lite better solve this problem? @Haroenv @francoischalifour