Skip to content

fix(specs): getObject return object #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix(specs): getObject return object #3446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152424e
fix(search): getObject return object
millotp Jul 29, 2024
335582f
disable js playground for now
millotp Jul 30, 2024
a778e22
Merge branch 'main' into fix/get-object
millotp Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/buildClients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ async function buildLanguage(
break;
case 'javascript':
await run('YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install', { cwd });
if (playground) {
await run('cd node && yarn build', { cwd });
} else {
if (!playground) {
const packageNames = gens.map(({ additionalProperties: { packageName } }) =>
packageName === 'algoliasearch' ? packageName : `@algolia/${packageName}`,
);
Expand Down
3 changes: 0 additions & 3 deletions specs/search/paths/objects/object.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,8 @@ get:
content:
application/json:
schema:
title: getObjectResponse
type: object
description: The requested record.
additionalProperties:
$ref: 'common/schemas.yml#/attribute'
'400':
$ref: '../../../common/responses/BadRequest.yml'
'402':
Expand Down