Skip to content

Conversation

@raed667
Copy link
Contributor

@raed667 raed667 commented Dec 14, 2023

When calling getRecommendations we need to make sure that the user doesn't have to pass objectID for the model recommended-for-you.

Otherwise this error will occur:

Property 'objectID' is missing in type '{ indexName: string; model: "recommended-for-you"; fallbackParameters: RecommendSearchOptions | undefined; queryParameters: (RecommendSearchOptions & { ...; }) | undefined; maxRecommendations: number | undefined; }' but required in type 'RecommendationsQuery'.

The fix should be a patch since the model is not publicly available yet.

marialungu
marialungu previously approved these changes Dec 15, 2023
@raed667 raed667 requested a review from shortcuts December 15, 2023 09:03
@raed667
Copy link
Contributor Author

raed667 commented Dec 21, 2023

Hey @francoischalifour , sorry i had some unpushed changes 😵‍💫 now, the PR should match what we talked about.

Copy link
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shortcuts shortcuts merged commit f94ce64 into master Jan 9, 2024
@shortcuts shortcuts deleted the fix-recommend-recommended-for-you-type branch January 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants