Skip to content

fix(transporter): error for too high timeout values #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: v4
Choose a base branch
from
Draft

fix(transporter): error for too high timeout values #1272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142d5e2
fix(transporter): error for too high timeout values
Haroenv May 21, 2021
f5628af
Merge branch 'master' into feat/timeout-max
Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/transporter/src/createTransporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import {
} from '.';
import { retryableRequest } from './concerns/retryableRequest';

// setTimeout is using uint32, so this is the maximum in ms and 5x is the max timeout multiplier
const MAX_TIMEOUT_VALUE = 0x7fffffff / 5000;

export function createTransporter(options: TransporterOptions): Transporter {
const {
hostsCache,
Expand All @@ -23,6 +26,16 @@ export function createTransporter(options: TransporterOptions): Transporter {
headers,
} = options;

if (
timeouts.connect > MAX_TIMEOUT_VALUE ||
timeouts.read > MAX_TIMEOUT_VALUE ||
timeouts.write > MAX_TIMEOUT_VALUE
) {
throw new Error(
`Timeout values can be no higher than setTimeout accepts (in seconds), ${MAX_TIMEOUT_VALUE}`
);
}

const transporter: Transporter = {
hostsCache,
logger,
Expand Down