Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Conversation

@FluencyMatt
Copy link

A previous pull request (#23) from @raymondmuller to add keyboard navigation failed merging due reduced unit test coverage, so I beefed it up where it was lacking.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 42

  • 34 of 35 (97.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.8%) to 75.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/VueBootstrapTypeaheadList.vue 29 30 96.67%
Totals Coverage Status
Change from base Build 38: 5.8%
Covered Lines: 71
Relevant Lines: 93

💛 - Coveralls

@Hawxy
Copy link

Hawxy commented Nov 29, 2018

@alexurquhart could this be merged?

@FluencyMatt
Copy link
Author

@alexurquhart is there something we can do to push this through?

@micon4sure
Copy link

Aww damn. I added keyboard controls too, didn't see this pull request. And it's been here more than 3 months. Save to say this repo is dead?

@Hawxy
Copy link

Hawxy commented Mar 8, 2019

I've personally just taken the source and integrated the changes I needed. Also allowed me to remove stuff I don't use and reduce it down to 2 files.

@mattzollinhofer
Copy link

This PR (and one or two others) is the exact reason I wanted to revive (but ended up having to fork: https://github.com/mattzollinhofer/vue-typeahead-bootstrap) this repository. I really wanted a more accessible tool to use and I saw this (and other) PRs that had already been submitted to solve the problem!

To that end, I merged in functionality that I think meets this need here: mattzollinhofer/vue-typeahead-bootstrap@6646027. This implementation is mildly different but I believe the outcome is essentially the same.

Thanks again and chime in here or on the fork if you have any other thoughts! 😄

You can find the functionality on npm here: https://www.npmjs.com/package/vue-typeahead-bootstrap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants