[Bug] Crash on Windows 7 SP1

[sudongg]

I try to run on win7 and get a crash

Problem signature :
Problem event name : APPCRASH
Application name : flutter_windows_angle_d3d_texture_example.exe
Application version : 1.0.0.0
Application Timestamp : 63116ca2
Fault Module name : flutter_windows_angle_d3d_texture_plugin.dll
Fault Module Version : 0.0.0.0
Fault Module Timestamp: 63116c98
Exception Code : c0000005
Exception Offset : 00000000000032a1
OS Version : 6.1.7601.2.1.0.768.2
Locale ID: 2052
Additional Information 1: 0336
Additional Information 2: 03364a7e80ae3f1737cf664e35c02d23
Additional Information 3: 248b
Additional Information 4: 248b1bdd3e8b77476ea68023c7d3ef5a

[alexmercerind]

I don't have a device which supports Windows 7, so I can't help.

Either-way, this information you shared is of literally zero use.
A meaningful crash stack-trace along-side (with debug symbols) still could be somewhat helpful.

Sorry.

[sudongg]

I tried to troubleshoot the problem. At first, D3D11CreateDevice failed. I tried to change it to

    const D3D_FEATURE_LEVEL featureLevels[] = {
        D3D_FEATURE_LEVEL_11_0, D3D_FEATURE_LEVEL_10_1, D3D_FEATURE_LEVEL_10_0,
        D3D_FEATURE_LEVEL_9_3,  D3D_FEATURE_LEVEL_9_2,  D3D_FEATURE_LEVEL_9_1,
    };

#ifndef NDEBUG
    unsigned int flags =
        D3D11_CREATE_DEVICE_BGRA_SUPPORT | D3D11_CREATE_DEVICE_DEBUG;
#else
    unsigned int flags = D3D11_CREATE_DEVICE_BGRA_SUPPORT;
#endif


    if (FAILED(hr = ::D3D11CreateDevice(
                   NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, flags, featureLevels,
                   ARRAYSIZE(featureLevels), D3D11_SDK_VERSION, &d3d11_device_,
                   NULL, &d3d11_device_context_))) {
      MessageBoxW(nullptr, L"D3D11CreateDevice FAILED.", L"Error", MB_OK);
      std::cerr << "D3D11CreateDevice FAILED." << std::endl;
    }

Success, then eglInitialize fails, I add in default_display_attributes fl9_3_display_attributes warp_display_attributes
EGL_PLATFORM_ANGLE_TYPE_D3D9_ANGLE is successful, but no content is displayed. I think the current eglInitialize only supports d3d9, but created D3D11Device and D3D11Texture, so nothing is displayed。

My purpose is to display video with libmpv, I don't know how much improvement using RegisterTexture will be compared to using bitmap, I know you are doing research on this, when can I see the results?

[alexmercerind]

I know you are doing research on this, when can I see the results?

I have already made video render & play successfully using libmpv inside Flutter Windows & Linux. I cannot afford to share my work publicly without any funding. It's very performant (due to hardware acceleration) even after screen recording.

And, it's written in 100% Dart, only Video widget code is in C/C++. Same is being used in Harmonoid.

libmpv+flutter.mp4

[sudongg]

Thank you for your current work. I will try to use this on win7 again. If there is any progress, I will tell you.

[alexmercerind]

I just got Windows 7 installed in a VM. I can confirm the crash.
I will try to fix this soon. Seems to be some kind of bad memory access.

[alexmercerind]

Hi @sudongg!

Apologies for the delay, I've been caught up with exams, college & life.

I added a fallback Direct3D 9 based initialization now, everything seems to succeed & therea are no crashes either. But, nothing shows on my Windows 7 VM (plain transparent Texture). On Windows 11, the glFlush call makes everything visible. But glFlush isn't the best thing here. I will appreciate if you can test or fix for Windows 7 (I only have VM).

I have created a new ANGLESurfaceManager class to easily host open-gl inside Flutter Windows.

BTW, I'll be making a new libmpv based video library public soon, as you asked above (using some of the work here): alexmercerind/dart_vlc#345.

Hoping for the best!

[alexmercerind]

One more information I'd like to give is that if I force Direct3D 9 (i e. remove InitializeD3D11), it works on Windows 11. So, Direct3D 9 configuration seems to be correct.

[sudongg]

@alexmercerind
It's a pity that I'm also a Windows 7 VM. I've already implemented opengl3 + dx9 to display mpv content on win7, but using skia is not flutter.
The playback effect is similar to that of using MPV directly.
I haven't implemented it yet on flutter.

[alexmercerind]

@alexmercerind It's a pity that I'm also a Windows 7 VM.

I've already implemented opengl3 + dx9 to display mpv content on win7, but using skia is not flutter. The playback effect is similar to that of using MPV directly. I haven't implemented it yet on flutter.

I have also done it in Flutter with hardware accelerated libmpv video rendering (D3D 11 backing & D3D 9 fallback).
Testing Windows 7 & ensure correct functioning is important. I'm not much sure if buffers swapping is causing the issue.

libmpv+flutter.mp4

[alexmercerind]

Can you see my Direct3D device & texture initialization or buffer swapping etc. (in this repository) & compare with yours?
I want this to work on Windows 7.

[alexmercerind]

I conclude my research.
It is not possible to use ANGLE on Windows 7 with Flutter Windows hardware-accelerated textures i.e. FlutterDesktopGpuSurfaceType.

When hosting ANGLE with Direct3D, we have two options:

• eglCreatePbufferFromClientBuffer + EGL_D3D_TEXTURE_2D_SHARE_HANDLE_ANGLE.
• eglCreateWindowSurface + HWND (used in Flutter & Chromium).

The texture API gives ability to share a HANDLE, which isn't working on Windows 7.
In-fact, when I force mpv to use eglCreatePbufferFromClientBuffer with --hwdec=dxva2 --gpu-context=angle --angle-egl-windowing=no, it falls back to non-ANGLE plain D3D hwdec on Windows 7. On the other hand, --angle-egl-windowing=yes keeps ANGLE running on Windows 7.

I think you also utilized eglCreateWindowSurface in your Skia rendering. If not so, I'd like to get informed.