Skip to content

Improve pdo mysql cleanup #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KentarouTakeda
Copy link

Hi, @alexandre-daubois

I have fixed some of the reviews of php#11879 . Could you please merge it?

  • fixed: merge conflict
  • fixed: typo
  • fixed: unnecessary drop table
  • not fixed: Tests that should be split

Regards.

@KentarouTakeda
Copy link
Author

It appears that CI is not set up for this pull request. So I ran my repository. (All passed.)

https://github.com/KentarouTakeda/php-src/actions/runs/6831300412?pr=3

@alexandre-daubois alexandre-daubois force-pushed the improve-pdo_mysql-cleanup branch 2 times, most recently from 641b27f to ea4d805 Compare November 15, 2023 13:36
@KentarouTakeda
Copy link
Author

Thank you for doing your best.
I'm sorry for doing something unnecessary.

@KentarouTakeda KentarouTakeda deleted the improve-pdo_mysql-cleanup branch November 17, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment