Fix: diagnostic checks using aleph SDK were broken #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the Python SDK does not check environment variables when configuring the API client and VM cache objects like the previous implementation did. Solution: pass the correct configuration explicitly when constructing these objects in the FastAPI example.
hoh
reviewed
Jul 7, 2023
| cache = VmCache() | ||
| cache = VmCache( | ||
| session=aiohttp.ClientSession( | ||
| connector=aiohttp.UnixConnector(path=os.environ["ALEPH_API_UNIX_SOCKET"]) |
Member
There was a problem hiding this comment.
The user of the SDK should not have to worry about that, the same code should work without a change on the developer's system and inside a microvm.
Member
|
This has been solved in the SDK, and a new version of the SDK should be used. |
Contributor
Author
|
Replaced by #371. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the Python SDK does not check environment variables when configuring the API client and VM cache objects like the previous implementation did.
Solution: pass the correct configuration explicitly when constructing these objects in the FastAPI example.