Fix: Upload Test wasn't mocked #73
Merged
+56
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHHukiewitz
previously requested changes
Oct 25, 2023
Member
MHHukiewitz
left a comment
MHHukiewitz
left a comment
There was a problem hiding this comment.
LGTM, but make sure that the test has the same syntax like before
1yam
force-pushed
the
lyam_fix_unit_upload
branch
2 times, most recently
from
17a54ac to
7bb282d
Compare
Solution: Mock AuthenticatedAlephHttpClient to remove server call
1yam
force-pushed
the
lyam_fix_unit_upload
branch
from
7bb282d to
e61da29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The workflow is failing sometime during this test due to
ServerDisconnectErrors.Solutions
We can Mocked
AuthenticatedAlephHttpClientto remove server call