Skip to content

Fix: Invalid handling of optional value #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix: Invalid handling of optional value #56

merged 1 commit into from
Aug 28, 2023

Conversation

@hoh
Copy link
Member

@hoh hoh commented Aug 28, 2023 •
edited
Loading

This caused mypy to error.

@hoh hoh requested a review from MHHukiewitz August 28, 2023 13:30
MHHukiewitz
MHHukiewitz approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 16e3769 into main Aug 28, 2023
@MHHukiewitz MHHukiewitz deleted the hoh-fix-mypy branch August 28, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoh @MHHukiewitz