Skip to content

Feature: download on ipfs client #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 12, 2023
Merged

Feature: download on ipfs client #36

merged 17 commits into from
Jul 12, 2023

Conversation

@1yam
Copy link
Member

@1yam 1yam commented Jul 10, 2023

Solutions:

  • Add a function called download_file_ipfs that downloads from ipfs.io/ipfs/.
  • Refactor the current download process to include:
    • Chunk size and storage into a buffer (BytesIO). (memory friendly)
  • Add a test for the download functionality.

hoh
hoh reviewed Jul 10, 2023
View reviewed changes
odesenfans
odesenfans requested changes Jul 10, 2023
View reviewed changes
1yam and others added 2 commits July 10, 2023 17:58
@hoh hoh mentioned this pull request Jul 10, 2023
Closed
@1yam 1yam requested a review from odesenfans July 11, 2023 12:22
odesenfans
odesenfans requested changes Jul 11, 2023
View reviewed changes
odesenfans
odesenfans requested changes Jul 12, 2023
View reviewed changes
odesenfans
odesenfans requested changes Jul 12, 2023
View reviewed changes
odesenfans
odesenfans previously approved these changes Jul 12, 2023
View reviewed changes
@odesenfans odesenfans merged commit 66a53af into aleph-im:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoh hoh hoh left review comments

@odesenfans odesenfans odesenfans approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1yam @hoh @odesenfans