Fix: SDK error when retrieving fallback private key, but the symlink was dead. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was dead. Solution: We add a check to determine if it is a symlink and if it is dead. In this case, we unlink it.
Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Olivier Desenfans <[email protected]>
hoh
reviewed
Jul 5, 2023
odesenfans
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The symlink can exist, but it can be dead. For example, unit tests may remove the file but not the symlink.
Solution: We add a check to determine if it is a symlink and if it is dead. In this case, we unlink it.