Problem: Signatures generated with Python 3.11 are invalid #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested changes
May 22, 2023
Contributor
odesenfans
left a comment
odesenfans
left a comment
There was a problem hiding this comment.
The current implementation of enum_as_str is incorrect. Also, maybe add tests for Python 3.11 in the CI?
Contributor
|
I think you need to rebase your PR. |
odesenfans
reviewed
Jul 10, 2023
odesenfans
previously approved these changes
Jul 10, 2023
The signature buffer is affected by the new formatting of string enums. Solution: use the value of the message type enum. Co-authored-by: Olivier Desenfans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature buffer is affected by the new formatting of string
enums.
Solution: use the value of the message type enum.
Co-authored-by: Olivier Desenfans [email protected]