Fix wrong chain account loading #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary: This PR involves a small change to the Highlight: - account = account_type(private_key, chain)
+ account = account_type(private_key)This change is likely to have a minimal impact on the codebase and is unlikely to introduce bugs. It is a routine refactoring task that would typically be handled by a developer with familiarity with the codebase. Therefore, the review complexity is categorized as 'BLUE'. |
philogicae
force-pushed
the
fix-wrong-account-loading
branch
from
1569fbc to
bd2a4fc
Compare
nesitor
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a solana account, it was always falling back to ETHAccount.