Skip to content

Fix _load_account when both string & path private key are provided #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix _load_account when both string & path private key are provided #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f57d25
Fix _load_account when both string & path private key are provided
philogicae Aug 28, 2024
31ccb74
Update src/aleph/sdk/account.py
olethanh Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/aleph/sdk/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,7 @@ def _load_account(
private_key_path: Optional[Path] = None,
account_type: Type[AccountFromPrivateKey] = ETHAccount,
) -> AccountFromPrivateKey:
"""Load private key from a string or a file.

Only keys that accounts that can be initiated from a
"""

assert not (
private_key_str and private_key_path
), "Private key should be a string or a filepath, not both."
"""Load private key from a string or a file. takes the string argument in priority"""

if private_key_str:
logger.debug("Using account from string")
Expand Down