fix: aiohttp.ClientSession needs to be created inside an async function #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethanh
approved these changes
Aug 14, 2024
Contributor
olethanh
left a comment
olethanh
left a comment
There was a problem hiding this comment.
not sure this is the best way but I have tested a few command with the http client and it still work properly
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the CI, it used to be a deprecated warning before but this is now an error.
Idk if this changes the way you are supposed to use this class and if it could break the existing API :/