Skip to content

Conversation

@philogicae
Copy link
Member

No description provided.

@philogicae philogicae requested review from 1yam and olethanh August 14, 2024 09:33
@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Aug 14, 2024
@github-actions
Copy link

Summary:

  • The PR includes a small change to the node_url initialization to remove the trailing slash, which is a common practice to ensure consistency in URL formatting.
  • This change is unlikely to introduce bugs and is a straightforward improvement to the codebase.

Highlighting relevant parts of the diff:

-        self.node_url = node_url
+        self.node_url = node_url.rstrip('/')

This change ensures that the node_url is consistently formatted without a trailing slash, which is a best practice for URL handling to avoid potential routing issues. The impact of this change is minimal and does not introduce any new functionality or substantial modifications to the existing logic.

Psycojoker
Psycojoker previously approved these changes Aug 14, 2024
@Psycojoker
Copy link
Collaborator

You can merge one you've run black on it for me

@philogicae philogicae requested review from Psycojoker and removed request for 1yam and olethanh August 14, 2024 13:20
@philogicae philogicae changed the title Fix to ensure no traling slash in crn node url Fix to ensure no trailing slash in crn node url Aug 14, 2024
@Psycojoker Psycojoker merged commit b1e33d0 into main Aug 14, 2024
@Psycojoker Psycojoker deleted the fix-ensure-no-trailing-slash branch August 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLUE This PR is simple and straightforward.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants