Skip to content

Conversation

@1yam
Copy link
Member

@1yam 1yam commented Aug 5, 2024

Problem:
In the Pay-As-You-Go (PAYG) flow, we need to retrieve the price of a program.

Solution:
Implement the get_program_price function to query the /api/v0/price/ endpoint and fetch the price of the program.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

"summary": "This PR introduces a new feature and modifies existing logic, which could have moderate risks and require system-level understanding.",
"highlights": [
{
"line": "@@ -40,7 +40,7 @@",
"highlight": "from ..query.responses import PostsResponse, PriceResponse"
},
{
"line": "@@ -241,6 +241,18 @@",
"highlight": "def watch_messages(self, ..."
},
{
"line": "@@ -241,18 +241,18 @@",
"highlight": "async def watch_messages(self, ..."
},
{
"line": "@@ -392,3 +397,17 @@",
"highlight": "async def watch_messages(self, ..."
},
{
"line": "@@ -392,17 +397,17 @@",
"highlight": "async def get_program_price(self, item_hash: str) -> PriceResponse:"
},
{
"line": "@@ -397,3 +397,17 @@",
"highlight": "async def get_program_price(self, item_hash: str) -> PriceResponse:"
},
{
"line": "@@ -397,17 +397,17 @@",
"highlight": "async with self.http_session.get(f"/api/v0/price/{item_hash}") as resp:"
},
{
"line": "@@ -402,3 +407,17 @@",
"highlight": "async def get_program_price(self, item_hash: str) -> PriceResponse:"
}
]
}

@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Aug 5, 2024
@1yam 1yam requested a review from hoh August 7, 2024 11:06
@Psycojoker Psycojoker requested a review from olethanh August 13, 2024 13:44
@1yam 1yam merged commit 2173274 into main Aug 16, 2024
@Psycojoker Psycojoker deleted the 1yam-feat-price branch August 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RED This PR is complex and may require more time to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants