Fix: Pythom 3.12 fails setup libsecp256k1 #132
Conversation
|
Summary: Highlight: - python-version: [ "3.9", "3.10", "3.11", "3.12" ]
+ python-version: [ "3.9", "3.10", "3.11" ] # An issue prevents Python 3.12 from workingThis change is considered 'BLUE' because it is a straightforward update to the workflow configuration, which does not introduce significant risks or changes to the core functionality of the project. The exclusion of Python 3.12 is noted, but the overall impact on the project is minimal. |
Psycojoker
left a comment
Psycojoker
left a comment
There was a problem hiding this comment.
LGFM except the comment
What is our long term plan to address this issue? Should we find another more maintained library?
When "using bundled libsecp256k1", the setup using `/tmp/venv/bin/hatch run testing:test` fails to proceed on Python 3.12.
That library `secp256k1` has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12.
The error in the logs:
```
File "/tmp/pip-build-env-ye8d6ort/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj
cmd_obj = self.command_obj[command] = klass(self)
^^^^^^^^^^^
TypeError: 'NoneType' object is not callable
[end of output]
```
See failing CI run:
https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722
The discussion on that topic is here: baking-bad/pytezos#370 |
When "using bundled libsecp256k1", the setup using
/tmp/venv/bin/hatch run testing:testfails to proceed on Python 3.12.That library
secp256k1has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12.The error in the logs:
See failing CI run:
https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722