-
Notifications
You must be signed in to change notification settings - Fork 9
Implement Hypervisor field on instances #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Hypervisor field on instances #107
Conversation
Solution: Implement hypervisor field into create_instance method
Note: The assistant is designed to provide clear explanations, but it may not always perfectly align with the actual complexity or risk level of a PR based on the provided information. It's important for users to understand these potential impacts before approving a 'BLACK' review. |
|
Nice, can we add a unit test to prevent regressions ? |
|
Tests are failing due to |
|
And now black is failing ^^' |
I already passed black on whole |
|
Tests fail due to: |
MHHukiewitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem: Instances with QEMU hypervisor cannot be created.
Solution: Implement hypervisor field into create_instance method.