Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Mar 5, 2024

Problem: Instances with QEMU hypervisor cannot be created.

Solution: Implement hypervisor field into create_instance method.

Solution: Implement hypervisor field into create_instance method
@nesitor nesitor requested review from MHHukiewitz and hoh March 5, 2024 16:19
@nesitor nesitor self-assigned this Mar 5, 2024
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 5, 2024
@github-actions
Copy link

github-actions bot commented Mar 5, 2024

  • Introduces new feature: 'HypervisorType'
  • Changes default value for hypervisor parameter in function 'create_instance'
  • Modifies multiple files (authenticated_http.py)
  • Potential impact on codebase could be high due to extensive changes and deep understanding of project architecture required

Note: The assistant is designed to provide clear explanations, but it may not always perfectly align with the actual complexity or risk level of a PR based on the provided information. It's important for users to understand these potential impacts before approving a 'BLACK' review.

@nesitor nesitor requested a review from aliel March 5, 2024 16:21
@hoh
Copy link
Member

hoh commented Mar 5, 2024

Nice, can we add a unit test to prevent regressions ?

@hoh
Copy link
Member

hoh commented Mar 6, 2024

Tests are failing due to isort, can you fix that ?

@MHHukiewitz
Copy link
Member

And now black is failing ^^'

@nesitor
Copy link
Member Author

nesitor commented Mar 6, 2024

And now black is failing ^^'

I already passed black on whole src folder, but in this project also we check the tests and the examples folder. Already fixed that issues.

@hoh
Copy link
Member

hoh commented Mar 6, 2024

Tests fail due to:

>       assert instance_message.content.hypervisor == HypervisorType.firecracker
E       AttributeError: 'InstanceContent' object has no attribute 'hypervisor'

Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 16de0ba into main Mar 6, 2024
@MHHukiewitz MHHukiewitz deleted the andres-feature-implement_hypervisor_field_instances branch March 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants