Cleanup: Pipfile was not used or maintained #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipfile and Poetry are great to manage dependencies, upgrade them, freeze them, etc. This is very useful when building web apps so everyone in the team uses the same version. They could be useful for pyaleph. However aleph-client is a library. We want users to be able to just pip install it from GitHub. Dependencies must be flexible so users can integrate it within their project. Solution: Remove Pipfile and Pipfile.lock
odesenfans
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipfile and Poetry are great to manage dependencies, upgrade them, freeze them, etc. This is very useful when building web apps so everyone in the team uses the same version. They could be useful for pyaleph.
However aleph-client is a library. We want users to be able to just pip install it from GitHub. Dependencies must be flexible so users can integrate it within their project.
Solution: Remove Pipfile and Pipfile.lock
Closes #76