This repository was archived by the owner on Apr 30, 2025. It is now read-only.
fastSmoothEmd and style fixes #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version appears to work, not sure if doing this from the other perspective would be better
Also remoing some uneeded c code.
Very inefficient (double for loop), but it works and can easily be refined
next step pulling edge case out of loop
seq_len instead of 1:length variable name lengths snake case names remove unused vars
seq_len incorrectly find/replaced function names
unused and incorrectly named arguments
…te/network-comparison into fastSmoothEMD-review
jack89roberts
changed the title
jack89roberts
changed the title
Closed
ots22
changed the title
This was referenced Jun 10, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains both #146 and #148