-
Notifications
You must be signed in to change notification settings - Fork 24
Support PureScript 0.9 and use purescript-spec for tests #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Also new to purescript, but hopefully this will be of some vague use. Looks like something in the browser is expecting certain nodejs properties to be available -
|
|
Thanks for taking the time to take a look at this btw :) |
|
Had a little go at this myself. No luck getting the spec tests to run unfortunately, but I switched back to the quickcheck ones and got those running ok (although maybe you did too? :) ) - only one failure which I haven't investigated yet. The changes I made are here: actionshrimp@caad64f And I ran: to generate the test bundle. Then had to call |
|
Would love to see this get more attention and help. Wish I could offer it myself! |
|
Hi! Maybe I could help (original author of purescript-spec). Not sure really what's going on here, but at a quick glance I see you're using the standard runner, which is for NodeJS, but it seems you are manipulating the DOM and need to run tests in a browser. Correct? In that case you should try https://github.com/owickstrom/purescript-spec-mocha instead, which bypasses the Node stuff and runs tests using the Mocha API. |
I can split this into 2 separate PRs if needed.
So far I have a problem with running tests. I have updated them to use
purescript-spec, but still couldn't run them in browser. Right now when I opentest/test.htmlI get this error:I'd appreciate any hints, since I'm new to PureScript.