Added id-length rule to eslintrc

[amsardesai]

This helps make sure variable names are longer than 1 character.

Single letter variable names are almost guaranteed to be completely non descriptive, this makes sure our variable names are longer than that.

Documentation on the id-length rule: http://eslint.org/docs/rules/id-length.html

[justjake]

please add the id-length documentation URL to your PR as a comment, following the style of the rest of the eslintrc.

[amsardesai]

Done!

[toxicFork]

@amsardesai What variable do you recommend using for "for loops"?

[amsardesai]

@toxicFork I generally try to avoid using for loops if I could use map, forEach, or filter instead. If I have to use for loops, I think just calling the variable name index seems like the best way to do it.

for (var index = 0; index < someLength; index++) {
    ...
}

What do you think?

[macebedo]

For the "for loop"... I've always use "ctr". These loops involves counter. ctr for short. Simple enough for me.

[gausie]

What are people's opinions on adding an exception for _, typically used by lodash and underscore?

[tomek-he-him]

@justjake @hshoff @gausie, I also got bitten by it. There are other valid uses:

• h in hyperscript, virtual-dom and @cycle/core.
• m in mithril.
• $, we all know where. Brr!

[toxicFork]

Also anything to do with geometry and math, e.g. THREE.Vector3.{x, y, z} and many others. It will remain disabled in all my configs.

[tomek-he-him]

@toxicFork Yeah, true.

Generally I’m no fan of one-letter variables – but how else can you name x?

[justjake]

Turns out no one likes this rule. Will turn it back off eventually

[tomek-he-him]

👍 👍

[gausie]

Thanks!