Implicit return + single expression #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomek-he-him
changed the title
README.md
Outdated
Member
There was a problem hiding this comment.
Let's make this 8.3 and have the good bad examples nestled up underneath.
Member
|
Couple of comments, love the added clarity. Thanks @tomekwi! |
Author
|
Thanks for the comments @hshoff 👍 . I can come back to this tomorrow morning, European time. Until then! |
Author
|
🏁 Sorry for scattering the changes over so many commits. I can rebase if you don’t mind losing your line comments @hshoff. |
Member
|
🏆 |
hshoff
added a commit
that referenced
this pull request
Aug 13, 2015
Implicit return + single expression
Collaborator
There was a problem hiding this comment.
This change doesn't hold the original intent of the text where parens are ok to omit only when you're using implicit return, otherwise they're required. cc @ljharb
Collaborator
There was a problem hiding this comment.
Let's please revert this text then, and also ensure the eslint plugin enforces it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438.
I’ve upgraded the note about argument parens to a new rule – it reads better this way.