Add section about not spreading props #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @ljharb |
ljharb
requested changes
Nov 1, 2017
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this is great!
Let's also suggest using https://npmjs.com/prop-types-exact on Component propTypes whenever possible as well, to help prevent bugs sooner :-)
react/README.md
Outdated
| ``` | ||
|
|
||
| - Use spread props sparingly. | ||
| > Why? Otherwise you're more likely to pass unnecessary props down to components. And for React 15 and older, you could [pass invalid HTML attributes to the DOM](https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html). |
Collaborator
There was a problem hiding this comment.
I think it's React < 15.2 or 15.3? Let's be specific here :-)
maggielove
force-pushed
the
spread-props
branch
2 times, most recently
from
e7b04b3 to
99076f5
Compare
Contributor
Author
|
Thanks @ljharb ! This is ready for re-review. :) I'm not sure why the Travis build is failing--looking into it. |
Collaborator
|
Tests will now pass once this is rebased on master. |
maggielove
force-pushed
the
spread-props
branch
from
99076f5 to
5682155
Compare
Contributor
Author
|
@ljharb Whenever you get a chance, I made your suggested changes. What do you think -- does it need more edits? |
ljharb
approved these changes
Nov 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1443