Missing no-undef in .eslintrc

[BaoDelta]

I think you should turn this rule on by default.

http://eslint.org/docs/rules/no-undef

This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

[ljharb]

We do have https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/.eslintrc#L180

[BaoDelta]

Sorry, I do not know that react/jsx-no-undef can cover no-undef. It works when I call eslint directly but not when I use gulp-eslint. Thank you anyway.

[jakezatecky]

I can also vouch that having react/jsx-no-undef turned on is not sufficient for no-undef to trigger in gulp-eslint or in an IDE such as WebStorm. At least it's easy to add that rule to the .eslintrc that's extending airbnb.

[sylvaingi]

Same here, without no-undef referencing a variable that does not exist (e.g. typo) is not caught by eslint.

[aaronjensen]

Yep, it doesn't catch it. Maybe it did at one point, but it no longer seems to.

[justjake]

ok.

[taion]

I'm seeing the same issue. Is this set of rules intended to be used on top of e.g. eslint:recommended, or is it supposed to be standalone?

[justjake]

Seems like a legit issue. Does anyone have a PR?

On Sat, Aug 22, 2015, 2:23 PM Jimmy Jia notifications@github.com wrote:

I'm seeing the same issue. Is this set of rules intended to be used on top
of e.g. eslint:recommended, or is it supposed to be standalone?

—
Reply to this email directly or view it on GitHub
#454 (comment).

[aaronjensen]

Sure @justjake, #484