Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Add streaming functionality #29

Closed
wants to merge 1 commit into from
Closed

Add streaming functionality #29

wants to merge 1 commit into from

Conversation

wingleung
Copy link

Preparation for #28

goatslacker
goatslacker suggested changes Oct 10, 2017
View reviewed changes
Copy link
Collaborator

@goatslacker goatslacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pull these out into a separate file by any chance? It would be rad so that we don't make the same mistake of including ReactDOMServer in the client bundles.

@wingleung
Copy link
Author

waiting for the split to happen, got it started here -> #45

@wingleung
Copy link
Author

closing, may be a long shot to use streaming json in hypernova.
If you want HTML streaming consider varnish ESI -> https://medium.com/vrt-digital-studio/server-side-rendering-react-components-as-a-service-9d6b887cb02a

@wingleung wingleung closed this Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@goatslacker goatslacker goatslacker requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wingleung @goatslacker