(docs)[python-sdk]: Added specs documentation for the Gui service #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandinosaso
force-pushed
the
fe-6387-spec-gui-service
branch
2 times, most recently
from
93bed1d to
461fa47
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…Added specs documentation for the Gui service
sandinosaso
force-pushed
the
fe-6387-spec-gui-service
branch
from
461fa47 to
0000f7a
Compare
|
|
||
| **itemId**: SPEC-GUI-SERVICE | ||
| **itemType**: Software Item Spec | ||
| **itemFulfills**: SWR-SYSTEM-GUI-INTERFACE-1 |
There was a problem hiding this comment.
where is this SWR from?
| # Auto-discovery pattern with conditional loading | ||
| if find_spec("nicegui"): | ||
| from ._error import PageBuilder as ErrorPageBuilder | ||
| from ._frame import HEALTH_UPDATE_INTERVAL, USERINFO_UPDATE_INTERVAL, frame |
There was a problem hiding this comment.
USERINFO_UPDATE_INTERVAL is not exported in all despite being mentioned as exported, i dont know if it matters, resolve if not
Comment on lines
+500
to
+511
| ## Appendix A: Verified Implementation Status | ||
|
|
||
| | Component | Implementation Status | Evidence Location | | ||
| |-----------|----------------------|-------------------| | ||
| | Frame Component | ✅ Complete | `_frame.py` | | ||
| | Theme Component | ✅ Complete | `_theme.py` | | ||
| | Error Handler | ✅ Complete | `_error.py` | | ||
| | CLI Integration | ✅ Complete | `cli.py` | | ||
| | Auto-Discovery | ✅ Complete | `__init__.py` | | ||
| | WSI GUI Pattern | ✅ Complete | `wsi/_gui.py` | | ||
| | QuPath GUI Pattern | ✅ Complete | `qupath/_gui.py` | | ||
| | Configuration Constants | ✅ Complete | `_frame.py` | |
There was a problem hiding this comment.
are we planning to update this with components that are not yet implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Software Item Specification for GUI service following the QuPath specification format.
Acceptance Criteria:
SPEC-{MODULE_NAME_UPPER}-SERVICE.mdin project rootSPEC-GUI-SERVICE.md