-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add software architecture doc #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ketryx
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave some netpick and questions
SOFTWARE_ARCHITECTURE.md
Outdated
Multi-layered testing approach: | ||
|
||
- **Unit Tests**: Individual component testing with >85% coverage requirement | ||
- **Integration Tests**: Module interaction testing with real API calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: By definition an integration test should not call real API this is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to verify if that is integration
083094c
to
980cc6b
Compare
f365278
to
587d486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
587d486
to
73131d6
Compare
No description provided.