Skip to content

Conversation

muhabalwan-aginx
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@sandinosaso sandinosaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some netpick and questions

Multi-layered testing approach:

- **Unit Tests**: Individual component testing with >85% coverage requirement
- **Integration Tests**: Module interaction testing with real API calls
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: By definition an integration test should not call real API this is wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to verify if that is integration

@muhabalwan-aginx muhabalwan-aginx changed the title Draft: Add initial draft for SWA of python-sdk Add Software Architecture md Aug 19, 2025
@muhabalwan-aginx muhabalwan-aginx force-pushed the ketryx-software-architecture branch from 083094c to 980cc6b Compare August 19, 2025 12:14
@muhabalwan-aginx muhabalwan-aginx changed the title Add Software Architecture md feat: add Software Architecture md Aug 19, 2025
@muhabalwan-aginx muhabalwan-aginx changed the title feat: add Software Architecture md feat: add software architecture doc Aug 19, 2025
@muhabalwan-aginx muhabalwan-aginx self-assigned this Aug 25, 2025
@muhabalwan-aginx muhabalwan-aginx force-pushed the ketryx-software-architecture branch 3 times, most recently from f365278 to 587d486 Compare September 1, 2025 11:44
@carlosaignostics carlosaignostics self-requested a review September 2, 2025 07:50
Copy link
Collaborator

@sandinosaso sandinosaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@muhabalwan-aginx muhabalwan-aginx force-pushed the ketryx-software-architecture branch from 587d486 to 73131d6 Compare September 3, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants