-
Notifications
You must be signed in to change notification settings - Fork 12
Ensure interior empty list items and some nbsp are not stripped away #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
spec/tinymce_examples_spec.rb
Outdated
| HTML | ||
|
|
||
| markup = <<~MARKUP | ||
| test_test*test*_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this markup correct? When I put that markup into JIRA it is not formatted, I still see the * and _.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the correct way to do this is test{_}test{*}test*_.
spec/tinymce_examples_spec.rb
Outdated
| HTML | ||
|
|
||
| markup = <<~MARKUP | ||
| *test * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also does not give the result I expect in JIRA. I see the * instead of the text being bold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only way I can get this formulation (generated by tinymce when applying formatting to highlighted text or nested formats across words, IIRC) to work in JIRA is something like: *test {*}test. TinyMCE does give us the nbsp in these contexts but we throw it away for a normal space.
Alternatives like shifting the padding spaces outside the tags would force an extra auto-update loop between JIRA and Aha! to normalize.
This actually isn't supported in Jira. Jira markdown always uses
{code} tags.
The first commit here adds a Gemfile and rspec to the gemspec for easier development, and reworks the test suite with some custom rspec helpers to remove boilerplate, and makes use of the indentation-aware
<<~HEREDOCto add some consistency.It meaningfully changes neither library code nor spec code.
The second commit contains specs written when trying to repro and debug small errors observed by customers during editing experiences with TinyMCE, hence the name
tinymce_examples_spec.<li>s are no longer stripped are no longer stripped away