Skip to content

Conversation

@christhekeele
Copy link

@christhekeele christhekeele commented Aug 1, 2017

The first commit here adds a Gemfile and rspec to the gemspec for easier development, and reworks the test suite with some custom rspec helpers to remove boilerplate, and makes use of the indentation-aware <<~HEREDOC to add some consistency.

It meaningfully changes neither library code nor spec code.

The second commit contains specs written when trying to repro and debug small errors observed by customers during editing experiences with TinyMCE, hence the name tinymce_examples_spec.

  • interior empty <li>s are no longer stripped
  • certain &nbsp; are no longer stripped away
  • adds some tests for extra percents in output from span quicktags fixed by jeremy previously
  • adds some tests for probing around issues with whitespace in tables

@christhekeele christhekeele requested a review from k1w1 August 2, 2017 19:14
HTML

markup = <<~MARKUP
test_test*test*_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this markup correct? When I put that markup into JIRA it is not formatted, I still see the * and _.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the correct way to do this is test{_}test{*}test*_.

HTML

markup = <<~MARKUP
*test *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also does not give the result I expect in JIRA. I see the * instead of the text being bold.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way I can get this formulation (generated by tinymce when applying formatting to highlighted text or nested formats across words, IIRC) to work in JIRA is something like: *test&nbsp;{*}test. TinyMCE does give us the nbsp in these contexts but we throw it away for a normal space.

Alternatives like shifting the padding spaces outside the tags would force an extra auto-update loop between JIRA and Aha! to normalize.

jjbohn and others added 5 commits August 21, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants