deps: use @agilgur5/tsconfig to simplify tsconfig
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is my own tsconfig base built on top of @tsconfig/strictest
- as you can see, it just reduces all the non-type-checking related config that @tsconfig/strictest doesn't cover
- TS doesn't yet support package `exports` for tsconfigs yet, hence the longer path into the package
- Relative paths in tsconfig bases are also relative _within_ node_modules, so have to repeat any relative paths here
- And due to this, I think it's better right now for `build` to extend the base here instead of the `build` tsconfig in `@agilgur5/tsconfig`
- I didn't fully think that one through when I made it tbh, though it still serves as a good example tsconfig
- Maybe that will be different in the future if TS changes or otherwise comes up with a solution to this
agilgur5
added
kind: internal
agilgur5
commented
Jun 13, 2022
Hamza65523
pushed a commit
to Hamza65523/react-signature-canvas
that referenced
this pull request
Nov 2, 2025
- this is my own tsconfig base built on top of @tsconfig/strictest
- as you can see, it just reduces all the non-type-checking related config that @tsconfig/strictest doesn't cover
- TS doesn't yet support package `exports` for tsconfigs yet, hence the longer path into the package
- Relative paths in tsconfig bases are also relative _within_ node_modules, so have to repeat any relative paths here
- And due to this, I think it's better right now for `build` to extend the base here instead of the `build` tsconfig in `@agilgur5/tsconfig`
- I didn't fully think that one through when I made it tbh, though it still serves as a good example tsconfig
- Maybe that will be different in the future if TS changes or otherwise comes up with a solution to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify
tsconfig.jsonby using my owntsconfig,@agilgur5/tsconfig.Details
this is my own
tsconfigbase built on top of@tsconfig/strictest@tsconfig/strictestdoesn't coverTS doesn't yet support package
exportsfortsconfigs yet (tsconfig "extends" field ignores "exports" field of source package microsoft/TypeScript#48665), hence the longer path into the packageRelative paths in
tsconfigbases are also relative withinnode_modules(ThecompilerOptions.outDirconfig is incorrectly resolved when in a shareable config microsoft/TypeScript#29172), so have to repeat any relative paths herebuildto extend the base here instead of thebuildtsconfig in@agilgur5/tsconfigtsconfig