deps: upgrade to rpt2 0.32.1 to fix configPlugin declarationMap issue
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue - Per b14060c, I ran into a bug in rpt2 when using it as a `configPlugin` and enabling declarationMaps - that bug was actually due to some code _I_ wrote in rpt2 and an edge case I didn't know existed (`configPlugin` usage means Rollup has no `output`) - so I eventually fixed it myself too - and in the past month I stepped up to help maintain rpt2 and fixed a ton of issues and improved lots of things per the release notes :) - since declarationMaps now work while using as a `configPlugin`, remove the workaround `tsconfig.rollup.json`
agilgur5
added
kind: internal
agilgur5
commented
Jun 11, 2022
There was a problem hiding this comment.
LGTM. Confirmed that the build still runs (and CI passes too). package-lock.json gets to shrink a bit after ezolenko/rollup-plugin-typescript2#326 too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to rpt2
0.32.0+ to fix issues with using it as aconfigPluginwhile enablingdeclarationMapsDetails
Per b14060c, I ran into a bug in rpt2 when using it as a
configPluginand enablingdeclarationMaps: Runtime error when using asconfigPluginwith"declarationMap": trueezolenko/rollup-plugin-typescript2#310configPluginusage means Rollup has nooutput)sourceswhen no output ezolenko/rollup-plugin-typescript2#334since
declarationMaps now work while using as aconfigPlugin, remove the workaroundtsconfig.rollup.json