deps: use rollup-plugin-node-externals
#83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
the
kind: internal
agilgur5
force-pushed
the
deps-rollup-plugin-node-externals
branch
from
63fb3f7 to
0b00c7e
Compare
Owner
Author
|
Travis CI just didn't run for whatever reason so I finally bit the bullet and migrated to GH Actions in #84. Rebased on top of that now |
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 75 75
Branches 9 9
=========================================
Hits 75 75 Continue to review full report at Codecov.
|
- instead of the custom JS code I wrote
- I was thinking of separating that into a plugin, but someone already
did that!
- and, importantly, also covered submodules, unlike _most_ of the
externals plugins
- see regex here: https://github.com/Septh/rollup-plugin-node-externals/blob/11a7b4454f57c76436e71ecead0cc59ab0cc3b80/src/index.ts#L106
- put it _before_ `node-resolve` as the docs state
- reduces my code a bit, which is always nice, and will make it easier
to split my Rollup config into its own "preset" package later on
agilgur5
force-pushed
the
deps-rollup-plugin-node-externals
branch
from
0b00c7e to
ce2411a
Compare
agilgur5
added
the
scope: dependencies
agilgur5
commented
Jun 11, 2022
Owner
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM, yay for simpler code!
I did also confirm locally that this produces an equivalent bundle ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
rollup-plugin-node-externalsinstead of customexternalcodeDetails
instead of the custom JS code I wrote
put it before
node-resolveas the docs statereduces my code a bit, which is always nice, and will make it easier to split my Rollup config into its own "preset" package later on