deps: update node-canvas, Node, actions, + npm audit fix
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `node-canvas` to latest v3 to work with newer, non-EoL Node versions - also less deps like `node-pre-gyp` etc - update CI matrix to use LTS Node 18+ - run `npm audit fix` after
agilgur5
added
kind: internal
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
changed the title
node-canvas, Node, + npm audit fixnode-canvas, Node, actions, + npm audit fix
agilgur5
commented
Dec 31, 2024
Owner
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
✅ CI all green with the new matrix and deps and changes LGTM
agilgur5
added a commit
that referenced
this pull request
Jan 3, 2025
deps: update `node-canvas`, Node, + `npm audit fix` - update `node-canvas` to latest v3 to work with newer, non-EoL Node versions - also less deps like `node-pre-gyp` etc - update CI matrix to use LTS Node 18+ - update `actions/checkout` and `actions/setup-node` to use non-EoL Node runtimes as well - the primary breaking change in updating [both to their](https://github.com/actions/checkout/releases/tag/v4.0.0) [respective v4 releases](https://github.com/actions/setup-node/releases/tag/v4.0.0) is the Node runtime update - run `npm audit fix` after (cherry picked from commit cf5b7c8) - fixed merge conflicts with other surrounding deps - basically only `node-canvas` updated and nothing else
Hamza65523
pushed a commit
to Hamza65523/react-signature-canvas
that referenced
this pull request
Nov 2, 2025
…5#115) deps: update `node-canvas`, Node, + `npm audit fix` - update `node-canvas` to latest v3 to work with newer, non-EoL Node versions - also less deps like `node-pre-gyp` etc - update CI matrix to use LTS Node 18+ - update `actions/checkout` and `actions/setup-node` to use non-EoL Node runtimes as well - the primary breaking change in updating [both to their](https://github.com/actions/checkout/releases/tag/v4.0.0) [respective v4 releases](https://github.com/actions/setup-node/releases/tag/v4.0.0) is the Node runtime update - run `npm audit fix` after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
node-canvasand CI matrix to use non-EoL NodeDetails
node-canvasto latest v3 to work with newer, non-EoL Node versionsnode-pre-gypetcactions/checkoutandactions/setup-nodeto use non-EoL Node runtimes as wellnpm audit fixafterNotes to Reviewers