v0.1.3 -- (env/deps): use agilgur5/tsdx fork for esModuleInterop etc #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 44 44
Branches 13 13
=====================================
Hits 44 44Continue to review full report at Codecov.
|
agilgur5
commented
Dec 4, 2019
Owner
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
Looks good, not much to see here
- this uses my fork which merged my PR/commit that fixes the missing
__esModule in CJS build output
- which has been an issue in this library since adopting tsdx, as
that's still an undocumented bug in tsdx
- the bug means that default imports get transpiled to x = require
instead of { default: x } = require
- which affects anyone using CJS and importing the default export
- and most apps still transpile down, as do most test runners,
so basically it affects almost everyone using the default
- for more details, see #12
- until this fix is merged and released in the root library, will
be using this fork
- it also has my recently merged PR/commit that changes the cacheRoot
to ./node_modules/.cache/ instead of ./rts2_cache_* directories
- can remove them from gitignore and they no longer clutter app root
agilgur5
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses my fork which merged my commit that fixes the missing
__esModule in CJS build output
that's still an undocumented bug in tsdx
be using this fork
it also has my recently merged commit that changes the cacheRoot to
./node_modules/.cache/ instead of ./rts2_cache_* directories
Fixes #12 by using my fork as I'm not sure when jaredpalmer/tsdx#327 will be merged (it has yet to be reviewed)